Skip to content

guard against deprecation of binom_test #7404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023
Merged

guard against deprecation of binom_test #7404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/test_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1640,7 +1640,7 @@ def test_stochastic_depth_random(self, seed, mode, p):
counts += batch_size - non_zero_count
num_samples += batch_size

p_value = stats.binom_test(counts, num_samples, p=p)
p_value = stats.binomtest(counts, num_samples, p=p).pvalue
assert p_value > 0.01

@pytest.mark.parametrize("seed", range(10))
Expand Down
4 changes: 2 additions & 2 deletions test/test_transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1445,7 +1445,7 @@ def test_random_order():
if out == resize_crop_out:
num_normal_order += 1

p_value = stats.binom_test(num_normal_order, num_samples, p=0.5)
p_value = stats.binomtest(num_normal_order, num_samples, p=0.5).pvalue
random.setstate(random_state)
assert p_value > 0.0001

Expand Down Expand Up @@ -1851,7 +1851,7 @@ def test_random_erasing(seed):
aspect_ratios.append(h / w)

count_bigger_then_ones = len([1 for aspect_ratio in aspect_ratios if aspect_ratio > 1])
p_value = stats.binom_test(count_bigger_then_ones, trial, p=0.5)
p_value = stats.binomtest(count_bigger_then_ones, trial, p=0.5).pvalue
assert p_value > 0.0001

# Checking if RandomErasing can be printed as string
Expand Down