Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NWC SAF GEO v2021 ASIIF-TF and ASII-GW dataset names #2673

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Dec 11, 2023

In NWC SAF GEO v2021 some of the dataset names inside the files have changed. This PR adds those. The old names in v2018 files are kept as-is, so the users need to migrate to the new ones.

Also some missing dataset names were added to silence few warnings.

@pnuu pnuu added enhancement code enhancements, features, improvements component:readers labels Dec 11, 2023
@pnuu pnuu requested a review from mraspaud December 11, 2023 12:46
@pnuu pnuu self-assigned this Dec 11, 2023
@pnuu pnuu requested a review from adybbroe as a code owner December 11, 2023 12:46
@pnuu pnuu requested a review from djhoese as a code owner December 11, 2023 13:42
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbe017c) 95.31% compared to head (fe50d42) 95.30%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2673      +/-   ##
==========================================
- Coverage   95.31%   95.30%   -0.02%     
==========================================
  Files         371      371              
  Lines       52435    52435              
==========================================
- Hits        49980    49971       -9     
- Misses       2455     2464       +9     
Flag Coverage Δ
behaviourtests 4.16% <ø> (-0.01%) ⬇️
unittests 95.91% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7168308574

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.886%

Totals Coverage Status
Change from base Build 7106990647: 0.0%
Covered Lines: 50108
Relevant Lines: 52258

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions, otherwise lgtm

satpy/etc/readers/nwcsaf-geo.yaml Show resolved Hide resolved
satpy/etc/readers/nwcsaf-geo.yaml Show resolved Hide resolved
@mraspaud mraspaud merged commit 90a3131 into pytroll:main Jan 22, 2024
16 of 19 checks passed
@pnuu pnuu deleted the nwc-saf-geo-v2021-asii-crrph branch January 22, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
Development

Successfully merging this pull request may close these issues.

Changes in NWC SAF GEO v2021 data
4 participants