-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NWC SAF GEO v2021 ASIIF-TF and ASII-GW dataset names #2673
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2673 +/- ##
==========================================
- Coverage 95.31% 95.30% -0.02%
==========================================
Files 371 371
Lines 52435 52435
==========================================
- Hits 49980 49971 -9
- Misses 2455 2464 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 7168308574Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions, otherwise lgtm
In NWC SAF GEO v2021 some of the dataset names inside the files have changed. This PR adds those. The old names in v2018 files are kept as-is, so the users need to migrate to the new ones.
Also some missing dataset names were added to silence few warnings.