-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AVHRR EPS reader to read cloud flags information #2639
Conversation
We can take care of the CI problems if this is something you'd be interested to merge. |
You mentioned in your issue that you're using an old version of Satpy. Does that mean that this functionality and variable used to work, but was removed? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2639 +/- ##
==========================================
+ Coverage 95.20% 95.22% +0.02%
==========================================
Files 354 356 +2
Lines 51370 51547 +177
==========================================
+ Hits 48908 49088 +180
+ Misses 2462 2459 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 6906945466Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
No, AFAIK this functionality was never there. We just forked, added this and then forgot about it. |
Ah ok, great. We'd really like a unit test to test this new variable. Thanks. |
pre-commit.ci autofix |
Thanks @fwfichtner. I did some refactoring of the code to make some of our checkers happy. It wasn't that your code was bad in anyway, just that your code being added tipped the scale for our checkers and revealed that the code was too complex. It is a little "cleaner" now. I'll merge this when CI tests pass. |
AUTHORS.md
if not there already