Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image overlays for single band data (requires trollimage 1.6+) #551

Merged
merged 7 commits into from
Dec 20, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Dec 16, 2018

Requires pytroll/trollimage#28 to be merged and trollimage 1.6 to be released.

Additionally the documentation currently fails to build because pydecorate hasn't had a passing sphinx build on readthedocs in over a year. I think once it is built with a semi-recent version of sphinx it should include the necessary intersphinx inventory files on readthedocs.

@djhoese djhoese added enhancement code enhancements, features, improvements component:writers labels Dec 16, 2018
@djhoese djhoese added this to the v0.11 milestone Dec 16, 2018
@djhoese djhoese self-assigned this Dec 16, 2018
@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #551 into master will increase coverage by 0.44%.
The diff coverage is 89.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
+ Coverage   76.81%   77.26%   +0.44%     
==========================================
  Files         136      136              
  Lines       19029    19124      +95     
==========================================
+ Hits        14618    14776     +158     
+ Misses       4411     4348      -63
Impacted Files Coverage Δ
satpy/tests/test_writers.py 97.81% <100%> (+0.26%) ⬆️
satpy/writers/__init__.py 86.18% <70%> (+9.46%) ⬆️
satpy/tests/test_readers.py 98.16% <0%> (-0.44%) ⬇️
satpy/readers/__init__.py 94.38% <0%> (+0.03%) ⬆️
satpy/readers/hrit_base.py 80.74% <0%> (+1.24%) ⬆️
satpy/readers/yaml_reader.py 92.57% <0%> (+3.57%) ⬆️
satpy/readers/seviri_l1b_hrit.py 51.41% <0%> (+6.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f931e3...78f9125. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 76.642% when pulling 97ef3da on djhoese:feature-single-band-coastlines into 129cba2 on pytroll:master.

@coveralls
Copy link

coveralls commented Dec 16, 2018

Coverage Status

Coverage increased (+0.4%) to 77.243% when pulling 78f9125 on djhoese:feature-single-band-coastlines into 2f931e3 on pytroll:master.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice to have this feature implemented, thanks!

satpy/writers/__init__.py Outdated Show resolved Hide resolved
satpy/writers/__init__.py Show resolved Hide resolved
satpy/writers/__init__.py Show resolved Hide resolved
satpy/writers/__init__.py Show resolved Hide resolved
@djhoese
Copy link
Member Author

djhoese commented Dec 17, 2018

Pydecorate's documentation has now been rebuilt and the intersphinx links now pass however the reader table looks like it has some indentation issues. I'll fix that in the related reader rename PR.

@djhoese
Copy link
Member Author

djhoese commented Dec 19, 2018

Tests are currently failing due to a bug in trollimage 1.6.0 that will be fixed in 1.6.1 via pytroll/trollimage#34

@djhoese djhoese merged commit 3f43d5e into pytroll:master Dec 20, 2018
@djhoese djhoese deleted the feature-single-band-coastlines branch December 20, 2018 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:writers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding coastlines to single channel not working
4 participants