Upgrade Font Awesome to version 5 #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Thanks! I'll merge this now and check everything when deployed. If something's get broken, I'll either fix it right away, or, in the worst case, revert the PR and we'll see what could be the next steps. |
honzajavorek
added a commit
that referenced
this pull request
Dec 2, 2020
|
Awesome. There were a few things missing etc., but I was able to find alternatives and I fixed it with no issues. I checked everything again and now all should be good 👍 Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change and should be thoroughly tested/reviewed.
What seems to break the most are icons as some of them were renamed or categorized differently
(example:
fa fa-facebookvsfab fa-facebook) in FA 5, I tried to spot as much as possible but still there mightbe stuff I missed.