Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options now drop invalid keywords from kwargs #1465

Merged
merged 3 commits into from May 21, 2017

Conversation

Projects
None yet
2 participants
@jlstevens
Copy link
Contributor

jlstevens commented May 19, 2017

PR to fix #1463 - invalid keywords weren't actually being skipped (i.e dropped from kwargs) which meant invalid values were being set on the options tree.

If the tests go green I'll add a unit test to make sure this stays fixed.

@jlstevens jlstevens referenced this pull request May 19, 2017

Closed

%opts break after error #1463

@jlstevens

This comment has been minimized.

Copy link
Contributor Author

jlstevens commented May 19, 2017

@philippjfr Ready to review/merge. I had to restart one build because of a transient - it should pass like the others soon.

@philippjfr

This comment has been minimized.

Copy link
Contributor

philippjfr commented May 21, 2017

Looks good and a straightforward improvement.

@philippjfr philippjfr merged commit 4d50ab4 into master May 21, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 78.832%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the options_skip_fix branch May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.