Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed undefined variable bug in XArrayInterface #2674

Merged
merged 3 commits into from
May 12, 2018

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented May 11, 2018

Fixed undefined variable bug when slicing with tuples and added unit tests for grid slicing.

  • Add unit tests

@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: component: data labels May 11, 2018
@philippjfr
Copy link
Member Author

Ready to merge, test data was updated due to previous issues (so we can ignore the failing push build).

@jlstevens
Copy link
Contributor

I restarted the push build anyway and it is now green. Merging.

@jlstevens jlstevens merged commit 98f09ef into master May 12, 2018
@philippjfr philippjfr added this to the v1.10.4 milestone May 12, 2018
@philippjfr philippjfr deleted the xarray_undefined_variable branch July 4, 2018 11:14
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tag: component: data type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants