-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize FAQ #2959
Reorganize FAQ #2959
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I think this ordering makes much more sense. Can you state explicitly that only the ordering has changed, not the content? It's hard to be sure of that because diff doesn't work well for reorderings, but if you say it's true that's good enough for me...
out' (from plot components with their own sizes) and Bokeh building | ||
them 'outside in' (fitting plot components into a given overall size). | ||
Thus there is not currently any way to specify sizes in a way that is | ||
comparable between the two backends. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit seems like it should move up to be merged with the earlier question about how to size plots in mpl and bokeh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe keep this PR for just reorganization and do that in another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
@jbednar only the ordering has changed! Here's a quick check with Word: |
Makes a lot of sense to me! |
I can't see why the tests would be failing for this PR; I've restarted them, but to no avail... |
no idea xD |
Not sure what's up with those test failures, seeing them on other PRs too. I'll update the test data and then rebase this PR once it's fixed. |
@ahuang11 Would you mind rebasing the PR against current master? I've rebuilt the test data so the tests should pass then. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Start FAQ with questions about common things like how to label, re-range, adjust size, legend, and exporting, then some miscellaneous questions, and lastly advanced customization.