Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic overlay #367

Merged
merged 6 commits into from
Dec 20, 2015
Merged

Dynamic overlay #367

merged 6 commits into from
Dec 20, 2015

Conversation

philippjfr
Copy link
Member

This PR makes it possible to use return Overlays with changing keys in a DynamicMap callback. It's a sensitive change, which will require some more testing.

Note that while it now displays everything certain things do not yet work:

  • Legends do not yet change to reflect the new NdOverlay key or Overlay label
  • In matplotlib styles will not consistently update.

And certain things cannot work:

  • Cyclic styles cannot work with a DynamicMap as the total ordering is required during instantiation. Could consider raising a warning when an Element returned from a DynamicMap is given a cyclic style.
  • You cannot return more Elements or different types of Elements than are supplied during instantiation.

@philippjfr
Copy link
Member Author

We've opened some issues to improve the validation for DynamicMap return types and warning the user. For now though this PR is ready for merge.

jlstevens added a commit that referenced this pull request Dec 20, 2015
Improved display of Overlays returned by DynamicMaps
@jlstevens jlstevens merged commit 4d645b4 into master Dec 20, 2015
@philippjfr philippjfr deleted the dynamic_overlay branch December 20, 2015 16:58
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants