Small Bokeh tutorial/code improvements #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "<div class=\"alert alert-info\" role=\"alert\">\n", | ||
| " This tutorial contains a lot of bokeh plots, which may take a little while to load and render.\n", | ||
| "</div>\n", | ||
| "\n", |
There was a problem hiding this comment.
This does help but I was also thinking of submitting an issue to suggest some sort of loading placeholder for Bokeh plots. Would this be feasible/worthwhile?
There was a problem hiding this comment.
Does sound nice but I also don't know how feasible it is.
|
I've made a few comments but otherwise it looks ok to me. That said, there are a number of code changes that I assume will affect more than just the Bokeh tutorial. |
philippjfr
changed the title
philippjfr
force-pushed
the
bokeh_tutorials
branch
from
07d5dd6
to
555f0d1
Compare
|
Ready to merge now. |
|
Ok. Tests are passing so I'll merge now. |
jlstevens
added a commit
that referenced
this pull request
Feb 8, 2016
Small Bokeh tutorial/code improvements
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes for the Bokeh tutorials removing additional Element examples, which do not yet work, i.e. sidebar of ErrorBars and overlay of VectorFields. Also added bootstrap based warning messages to warn that Tutorials can take a minute to render because there's so many plots on the page.