Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed DynamicMap 'closed' mode to 'bounded' #485

Merged
merged 1 commit into from
Feb 10, 2016
Merged

Conversation

jlstevens
Copy link
Contributor

PR title says it all.

As far as I know, we are aware of (and can update) all code that may have used DynamicMap up until this point...

@jlstevens
Copy link
Contributor Author

Mathematically 'closed' and 'open' isn't the same as 'bounded' and 'unbounded'. I've left 'open mode' alone as I think 'unbounded' is too long and 'open' has fairly natural semantics (as opposed to 'closed' versus 'bounded').

@jbednar @philippjfr Any thoughts on this? This is our last chance to change it! I think 'counter' mode is unproblematic unless you feel there is something better. Maybe 'step' mode?

@philippjfr
Copy link
Member

Sounds clearer to me and there isn't much backward compatibility to worry about. I'll merge unless @jbednar raises any objections in the next few minutes.

@jlstevens
Copy link
Contributor Author

Yes, please merge as I have another PR that will operate on the same file.

@philippjfr
Copy link
Member

Okay, too late for objections :) I'll merge

philippjfr added a commit that referenced this pull request Feb 10, 2016
Renamed DynamicMap 'closed' mode to 'bounded'
@philippjfr philippjfr merged commit 06a64e1 into master Feb 10, 2016
@jlstevens jlstevens deleted the closed_to_bounded branch February 10, 2016 01:23
@philippjfr philippjfr added this to the 1.4.3 milestone Feb 10, 2016
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants