-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hamiltonian generation and instruction handling #87
Conversation
# Conflicts: # c3/libraries/fidelities.py
Filtering devices# with '#' will be ignored, and an empty message aborts the commit.
Optimize Lindblad calculation?
Change default ADAM learning rate to reasonable value.
Option to not overwrite unitaries Allow batching for vectorized propagation get dressed qubit frequencies and state labels from model
generalize pauli_basis
Add Transmon with full expansion Fixes of chip elements for full hamiltonian + Typing
unify usage of opt_map
Extend compexity of slepian_fourier function
option of projector to output any dimension Nicer printing
fixes in Quantity object extend bounds in set_value Additional flags and options in experiment update_parameter function in parametermap
add nophase fidelity
This pull request introduces 2 alerts and fixes 2 when merging 39583d7 into 40cb690 - view on LGTM.com new alerts:
fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## dev #87 +/- ##
==========================================
+ Coverage 47.54% 51.48% +3.94%
==========================================
Files 36 36
Lines 4556 5409 +853
==========================================
+ Hits 2166 2785 +619
- Misses 2390 2624 +234
Continue to review full report at Codecov.
|
This pull request fixes 2 alerts when merging 554e17f into 40cb690 - view on LGTM.com fixed alerts:
|
The test coverage goes down by more than a percent, do we wish to make this pull request complete by adding tests in this PR or would that come separately? |
This pull request fixes 2 alerts when merging 796a68f into 40cb690 - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging d06b224 into 40cb690 - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging 27b1c48 into 40cb690 - view on LGTM.com fixed alerts:
|
As noted by @shaimach for the purpose of reporting metrics and tracking changes, contributors/reviewers with write access (in this case @fedroy), please make sure the merge commit message (the one which appears when you try to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at all changes together and I can confirm that the code is ready for being merged.
Lots of useful new feature that also align well with future development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This merge most importantly has the ability to request time sliced hamiltonians form the LineComponents to get time dependent drift hamiltonians. Furthermore awg signal generation has been moved to the Instruction object giving the pulse positioning more options.
Many more new features and fixes are included in this merge, including: