Add "DWG/DXF Import..." description #2430

DelazJ · 2018-03-13T20:33:12Z

SrNetoChan

Added a few suggestions. At some point it's good to add a warning saying that the import into Geopackage may take some time, depending on the size of the CAD file.

SrNetoChan · 2018-03-13T23:36:29Z

source/docs/user_manual/managing_data_source/opening_data.rst

@@ -363,9 +363,34 @@ to the project. Layers are added with random style properties.
 .. need to be tested with dwg. How does dwg format behave when added to QGIS?


AFAIK, dwg are not readable using normal loading mechanism.

GDAL now has a opencad driver that reads DWG - but reading through OGR will not address symbology alike.

@jef-n, is it in the minimal version required for 3.0. I mean, could we say that dwg can be opened in 3.0 or should this statement be conditioned by a GDAL version? which one?

No, DWG import was introduced in 2.18. And our DWG import is independant of GDAL's DWG support (which didn't exist when the QGIS' DWG import was implemented; QGIS DWG support aims to also reproduce the symbology and layer structure from *CAD; importing via GDAL would only produce simple points, lines, polygons)

SrNetoChan · 2018-03-13T23:43:38Z

source/docs/user_manual/managing_data_source/opening_data.rst

@@ -363,9 +363,34 @@ to the project. Layers are added with random style properties.
 .. need to be tested with dwg. How does dwg format behave when added to QGIS?

 To keep the dxf/dwg structure and its symbology in QGIS, you may want to
-use the dedicated :menuselection:`DWG/DXF Import...` tool.
+use the dedicated :menuselection:`Project --> DWG/DXF Import...` tool. Indeed,
+the :guilabel:`DWG/DXF Import` dialog offers you to import in a GeoPackage


allows you to import into a GeoPackage?

imports into GeoPackage

SrNetoChan · 2018-03-13T23:52:54Z

source/docs/user_manual/managing_data_source/opening_data.rst

+* Then use the **[Import]** button to select the DWG/DXF file to use (one per
+  geopackage). The GeoPackage database will be automatically populated with the
+  drawing file content.
+* The |checkbox| :guilabel:`Expand block references` helps you copy the


I am not sure about this. AFAIK, blocks are groups of elements that can be repeated through the drawing. I would expect that the expand blocks would transform the existing blocks into normal elements.

@SrNetoChan correct.

Could someone come with a text, please? I'm far from CAD for maaannny years now and just pick the description from the "commit" help message #1580 (comment) (btw, really great to ease writers work. Thanks)

SrNetoChan · 2018-03-13T23:53:55Z

source/docs/user_manual/managing_data_source/opening_data.rst

+  drawing file content.
+* The |checkbox| :guilabel:`Expand block references` helps you copy the
+  transformed contents of the corresponding block for each block reference.
+* the |checkbox| :guilabel:`Use curves` promotes the layers geometry type to a


output layers?

SrNetoChan · 2018-03-14T00:03:34Z

source/docs/user_manual/managing_data_source/opening_data.rst

+another group for each of the selected layers in the list. Each subgroup
+contains vector layers for the point, line, label and area features of the
+respective layer. The style of each layer is setup so that it resembles the look
+it originally had in *CAD.


missing * ?

Picked from aforementioned description (i guess it was instead targeting softwares like LibreCAD, AutoCAD... ). Simply forgot that * is a special character and Travis would not like it.
Will change it.

You need to escape the *. I think \* will do

SrNetoChan · 2018-03-14T00:05:09Z

source/docs/user_manual/managing_data_source/opening_data.rst

+After the :file:`.dwg` or :file:`.dxf` data is imported into the GeoPackage
+database the list in the lower half of the dialog is populated with the layer
+list from the imported file. There you can select which layers to import into
+the QGIS project. A top level group is set for the drawing file and inside,


I would make a reference to the Group name label.

DelazJ · 2018-03-14T18:52:36Z

Thanks for your reviews

DelazJ

I made the requested changes but i'm not sure I really understand how this dialog is organized (and there's UX issue here imho - see inline comment ).
Also I could not understand what the "reload" button does: update the list of layers, reload the cad file, load again to the db, all of them? And at the same time what do the "import" and "load layers" button?
Maybe should I raise this in the issue tracker (but in case I missed something...)

DelazJ · 2018-03-25T14:26:17Z

source/docs/user_manual/managing_data_source/opening_data.rst

+* Specify which coordinate system the data in the DWG data is in;
+* Then use the **[Import]** button to select the DWG/DXF file to use (one per
+  geopackage). The GeoPackage database will be automatically populated with the
+  drawing file content. Depending on the size of the \*CAD file, this could


I think the automatic import is a UX killer: select the wrong CAD file and you have to wait for a long time: i think people expect to first add the cad layer (btw we should use qgsfilewidget for both data loader) and then consciously choose to import into the db.

DelazJ · 2018-03-25T14:36:27Z

source/docs/user_manual/managing_data_source/opening_data.rst

+layers from the imported file. There you can select which layers to add to the
+QGIS project:
+
+* At the top, set a :guilabel:`Group name` to group the drawing files in the


why is it required to add a group name (ok is disabled until set)?

the layers from the DWG appear in a group.

Yes, I saw that. My point was why do we require they are added in a group. layers are already added to their own group and now those groups are also added in a "bigger" group. Too many groups, no?
People can easily identify layers that come from the gpkg file. No need for a group (or at least, it should not be mandatory) imho. That said, this is the less puzzling feature in the dialog to me.

DelazJ · 2018-04-06T06:05:19Z

Status?
I'll open bug report for what look like issue to me and let undocumented the behavior I do not understand

(cherry picked from commit ae6f29f)

Add "DWG/DXF Import..." description

e21b5b0

DelazJ added the needs-backport label Mar 13, 2018

DelazJ requested a review from SrNetoChan March 13, 2018 20:33

SrNetoChan reviewed Mar 14, 2018

View reviewed changes

Add changes after review

f107ed2

DelazJ commented Mar 25, 2018

View reviewed changes

DelazJ merged commit ae6f29f into qgis:master Apr 22, 2018

DelazJ deleted the dxf branch April 22, 2018 11:00

DelazJ added a commit to DelazJ/QGIS-Documentation that referenced this pull request Apr 22, 2018

Add "DWG/DXF Import..." description (qgis#2430)

ff501e1

(cherry picked from commit ae6f29f)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add "DWG/DXF Import..." description #2430

Add "DWG/DXF Import..." description #2430

DelazJ commented Mar 13, 2018

SrNetoChan left a comment

SrNetoChan Mar 13, 2018

jef-n Mar 14, 2018

DelazJ Mar 14, 2018 •

edited

Loading

jef-n Mar 15, 2018

SrNetoChan Mar 13, 2018

jef-n Mar 14, 2018

SrNetoChan Mar 13, 2018

jef-n Mar 14, 2018

DelazJ Mar 14, 2018

SrNetoChan Mar 13, 2018

SrNetoChan Mar 14, 2018

DelazJ Mar 14, 2018

SrNetoChan Mar 15, 2018

SrNetoChan Mar 14, 2018

DelazJ commented Mar 14, 2018

DelazJ left a comment

DelazJ Mar 25, 2018

DelazJ Mar 25, 2018

jef-n Apr 8, 2018

DelazJ Apr 9, 2018

DelazJ commented Apr 6, 2018

		@@ -363,9 +363,34 @@ to the project. Layers are added with random style properties.
		.. need to be tested with dwg. How does dwg format behave when added to QGIS?

Add "DWG/DXF Import..." description #2430

Add "DWG/DXF Import..." description #2430

Conversation

DelazJ commented Mar 13, 2018

SrNetoChan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DelazJ Mar 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DelazJ commented Mar 14, 2018

DelazJ left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DelazJ commented Apr 6, 2018

DelazJ Mar 14, 2018 •

edited

Loading