Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose choice of distance unit for elevation profiles #53235

Merged
merged 6 commits into from
May 29, 2023

Conversation

nyalldawson
Copy link
Collaborator

This PR adds choices of distance units for elevation profiles. It's exposed both for the interactive elevation profiles (via the settings toolbar button) and for layout elevation profiles.

Users can pick to override the default (ie canvas map units) distance unit.

In layout profiles, there's also an option which controls where the distance unit suffixes should be placed. Options are to hide the suffixes, for all values, for the first value, last value or first and last values.

note it is currently NOT possible to expose unit selection for the vertical axis, as this is currently dimension-less and is blocked by missing vertical CRS handling in QGIS. See qgis/QGIS-Enhancement-Proposals#267

@nyalldawson nyalldawson added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting Profile tool labels May 26, 2023
@qgis-bot
Copy link
Collaborator

@nyalldawson

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@github-actions github-actions bot added this to the 3.32.0 milestone May 26, 2023
@qgis-bot
Copy link
Collaborator

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

Copy link
Member

@wonder-sk wonder-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

One thought: how about adding a space between numbers and distance units - "100 m" instead of "100m" ? It seems that's the correct way of writing according to SI - https://grammarhow.com/do-you-put-a-space-between-number-and-unit/

@nyalldawson
Copy link
Collaborator Author

@wonder-sk

how about adding a space between numbers and distance units

Done!

@github-actions
Copy link

@nyalldawson
A documentation ticket has been opened at qgis/QGIS-Documentation#8296
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Profile tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants