Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Add WMS parameter value to request only maptip for HTML feature info response #55823

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

pathmapper
Copy link
Contributor

@pathmapper pathmapper commented Jan 11, 2024

This is a proposal to add a new value HTML_FI_ONLY_MAPTIP for the existing WMS vendor parameter WITH_MAPTIP.

If set, the feature info HTML response includes only the maptip, which gives full control over the HTML response using e.g. the built-in maptip editor which has a nice preview since #52420 and also got other improvements in #54764.

This aims to be fully backward compatible while closing #20601.

Tests included.

@github-actions github-actions bot added this to the 3.36.0 milestone Jan 11, 2024
@pathmapper pathmapper closed this Jan 12, 2024
@pathmapper pathmapper reopened this Jan 12, 2024
Copy link

github-actions bot commented Jan 12, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit e13d9aa)

@pathmapper pathmapper force-pushed the only_maptip branch 2 times, most recently from 33f56c7 to 72b2438 Compare January 13, 2024 14:08
@Gustry Gustry added Server Related to QGIS server Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jan 15, 2024
@qgis-bot
Copy link
Collaborator

@pathmapper
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

@pathmapper

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@pathmapper
Copy link
Contributor Author

Any chance to get this in for 3.36?

Copy link
Contributor

@elpaso elpaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor comments.

src/server/services/wms/qgswmsparameters.cpp Outdated Show resolved Hide resolved
src/server/services/wms/qgswmsparameters.cpp Outdated Show resolved Hide resolved
@elpaso elpaso enabled auto-merge January 19, 2024 10:17
@elpaso elpaso merged commit 121aaa3 into qgis:master Jan 19, 2024
30 checks passed
Copy link

@pathmapper
A documentation ticket has been opened at qgis/QGIS-Documentation#8794
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Server Related to QGIS server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants