Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical CRS selection widget to vector layer properties #58162

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

nyalldawson
Copy link
Collaborator

@nyalldawson nyalldawson commented Jul 18, 2024

Follows the same behavior as the project setting, i.e.:

If the layer has a 3d crs set, then the widget is disabled with an explanatory note:

image

If the layer has a 2d crs set, then the user can select the appropriate vertical crs:

image

There's also a explanatory note detailing where vertical CRS are respected, along with a warning:

image

@nyalldawson nyalldawson added the NOT FOR MERGE Don't merge! label Jul 18, 2024
@github-actions github-actions bot added this to the 3.40.0 milestone Jul 18, 2024
Copy link

github-actions bot commented Jul 18, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 2e59231)

@nyalldawson nyalldawson added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting and removed NOT FOR MERGE Don't merge! labels Jul 30, 2024
@qgis-bot
Copy link
Collaborator

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

@nyalldawson

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@nyalldawson
Copy link
Collaborator Author

This is ready for merge

@nyalldawson nyalldawson merged commit b117fb9 into qgis:master Jul 31, 2024
37 checks passed
@nyalldawson nyalldawson deleted the vl_vert_crs branch July 31, 2024 20:44
@qgis-bot
Copy link
Collaborator

@nyalldawson
A documentation ticket has been opened at qgis/QGIS-Documentation#9187
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants