Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffers for marker symbols #58228

Merged
merged 14 commits into from
Aug 1, 2024
Merged

Buffers for marker symbols #58228

merged 14 commits into from
Aug 1, 2024

Conversation

nyalldawson
Copy link
Collaborator

This PR implements "buffers" for marker symbols. Just like label buffers, marker buffers are a halo effect around marker symbols designed to make the symbol more readable against different backgrounds.

Buffers are defined on a symbol level (not per symbol-layer), and are calculated and drawn using the shape of ALL the symbol layers in the marker. This makes them super-easy to configure, as getting the same result by hand would require many duplicate symbol layers and duplicate settings across these!

This change is designed to plug on of the (very few!) remaining large symbology gaps between ArcMap and QGIS, where ArcMap has had support for solid color marker "halos" for decades.

Sponsored by North Road, thanks to SLYR

Peek.2024-07-24.15-04.mp4

@nyalldawson nyalldawson added Requires Tests! Waiting on the submitter to add unit tests before eligible for merging Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jul 24, 2024
@qgis-bot
Copy link
Collaborator

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

@nyalldawson

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@github-actions github-actions bot added this to the 3.40.0 milestone Jul 24, 2024
Copy link

github-actions bot commented Jul 24, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 19b780f)

@nyalldawson nyalldawson removed the Requires Tests! Waiting on the submitter to add unit tests before eligible for merging label Jul 29, 2024
@qgis qgis deleted a comment from github-actions bot Jul 29, 2024
@qgis qgis deleted a comment from github-actions bot Jul 29, 2024
@nyalldawson
Copy link
Collaborator Author

The test mask updates here relate to the clang tidy warning fix in f2663f1, not directly related to this PR...

@qgis qgis deleted a comment from github-actions bot Jul 29, 2024
@qgis qgis deleted a comment from github-actions bot Jul 29, 2024
@qgis qgis deleted a comment from github-actions bot Jul 30, 2024
@qgis qgis deleted a comment from github-actions bot Jul 30, 2024
@qgis qgis deleted a comment from github-actions bot Jul 30, 2024
@nyalldawson
Copy link
Collaborator Author

I'll merge this later today if there's no objections

@nyalldawson nyalldawson merged commit b358ab8 into qgis:master Aug 1, 2024
30 checks passed
@nyalldawson nyalldawson deleted the symbol_buffer branch August 1, 2024 19:09
@qgis-bot
Copy link
Collaborator

qgis-bot commented Aug 1, 2024

@nyalldawson
A documentation ticket has been opened at qgis/QGIS-Documentation#9191
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants