disallow duplicate sample IDs in demux types/formats #126
Assignees
Labels
type:bug
Something is wrong.
Comments
|
This can be assigned to me. |
maxvonhippel
added a commit
to maxvonhippel/q2-types
that referenced
this issue
Jul 7, 2017
maxvonhippel
added a commit
to maxvonhippel/q2-types
that referenced
this issue
Jul 7, 2017
maxvonhippel
added a commit
to maxvonhippel/q2-types
that referenced
this issue
Jul 21, 2017
…"per-sample sequence" formats All changes in this commit are related to the "per-sample sequence" formats. Several changes: - Comments and blank lines are now supported in "per-sample sequence" manifest formats, including sniffers and transformers. - Duplicate samples are now additionally detected and disallowed in "relative path" manifest formats (previously this validation only happened in the "absolute path" manifest formats). - Error messages reported by transformers are both more precise and accurate. - Refactored sniffer and transformer code to reduce redundancy and perform consistent validation and parsing in all sniffers/transformers. - Added unit tests, increased coverage to 100% for "per-sample sequence" formats, and made existing unit tests and test data more robust. Fixes qiime2#126. Fixes qiime2#129. Fixes qiime2#132. Pair-programmed with @jairideout.
thermokarst
pushed a commit
that referenced
this issue
Jul 24, 2017
…"per-sample sequence" formats (#136) All changes in this commit are related to the "per-sample sequence" formats. Several changes: - Comments and blank lines are now supported in "per-sample sequence" manifest formats, including sniffers and transformers. - Duplicate samples are now additionally detected and disallowed in "relative path" manifest formats (previously this validation only happened in the "absolute path" manifest formats). - Error messages reported by transformers are both more precise and accurate. - Refactored sniffer and transformer code to reduce redundancy and perform consistent validation and parsing in all sniffers/transformers. - Added unit tests, increased coverage to 100% for "per-sample sequence" formats, and made existing unit tests and test data more robust. Fixes #126. Fixes #129. Fixes #132. Pair-programmed with @jairideout.
|
This came up again on the forum. It looks like this issue still exists for |
jairideout
pushed a commit
that referenced
this issue
Sep 28, 2017
fixes #126 fixes #143 pair programmed with @thermokarst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Came up on the forum: duplicate sample IDs should be disallowed with types
SampleData[SequencesWithQuality]andSampleData[PairedEndSequencesWithQuality](the fix would be implemented on those types' transformers).The text was updated successfully, but these errors were encountered: