Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: derep support for more input types #34

Merged
merged 1 commit into from
Nov 22, 2017
Merged

ENH: derep support for more input types #34

merged 1 commit into from
Nov 22, 2017

Conversation

gregcaporaso
Copy link
Member

@gregcaporaso gregcaporaso commented Nov 21, 2017 •
edited
Loading

Depends on qiime2/q2-types#161

Verified that all three of these input types work locally with real data.

@thermokarst thermokarst self-requested a review November 22, 2017 00:03
@thermokarst thermokarst self-assigned this Nov 22, 2017
thermokarst
thermokarst approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@thermokarst thermokarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, worked like a charm. Thanks @gregcaporaso!

@thermokarst thermokarst merged commit a8138d3 into qiime2:master Nov 22, 2017
@gregcaporaso gregcaporaso deleted the derep-joined branch November 22, 2017 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thermokarst thermokarst thermokarst approved these changes

Assignees

@thermokarst thermokarst

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregcaporaso @thermokarst