Skip to content

Commit dc938f7

Browse files
committed
addressing suggestions from @josenavas
1 parent 0a54881 commit dc938f7

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

qiita_pet/handlers/analysis_handlers.py

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -177,31 +177,28 @@ def post(self, analysis_id):
177177
Analysis.delete(analysis_id)
178178
msg = ("Analysis <b><i>%s</i></b> has been deleted." % (
179179
analysis_name))
180-
msg_level = "success"
180+
level = "success"
181181
except Exception as e:
182182
msg = ("Couldn't remove <b><i>%s</i></b> analysis: %s" % (
183183
analysis_name, str(e)))
184-
msg_level = "danger"
184+
level = "danger"
185185

186-
# redirecting to list of analysis but also passing messages and
187-
# we need to change the request.method to GET
188-
self.request.method = 'GET'
189-
ShowAnalysesHandler(self.application, self.request)._execute(
190-
[t(self.request) for t in self.application.transforms],
191-
message=msg, msg_level=msg_level)
186+
self.redirect(u"/analysis/show/?level=%s&message=%s" % (level, msg))
192187

193188

194189
class ShowAnalysesHandler(BaseHandler):
195190
"""Shows the user's analyses"""
196191
@authenticated
197-
def get(self, message='', msg_level=''):
192+
def get(self):
193+
message = self.get_argument('message', '')
194+
level = self.get_argument('level', '')
198195
user = self.current_user
199196

200197
analyses = [Analysis(a) for a in
201198
user.shared_analyses | user.private_analyses]
202199

203200
self.render("show_analyses.html", analyses=analyses, message=message,
204-
msg_level=msg_level)
201+
level=level)
205202

206203

207204
class ResultsHandler(StaticFileHandler, BaseHandler):

0 commit comments

Comments
 (0)