Fixing qiita_db/data.py #1327
Fixing qiita_db/data.py #1327
Conversation
| raw_data_count = TRN.execute_fetchlast() | ||
| if raw_data_count == 1 and RawData(raw_data_id).get_filepath_ids(): | ||
| raise QiitaDBError( | ||
| "Raw data (%d) can't be remove because it has linked " |
There was a problem hiding this comment.
It was like this before but ... remove->removed
|
👍 Looks good, just one question! |
| (status, self._id)) | ||
| with TRN: | ||
| if (status not in ('idle', 'linking', 'unlinking') and | ||
| not status.startswith('failed')): |
There was a problem hiding this comment.
Not sure why flake8 is not complaining about this one ...
There was a problem hiding this comment.
flake8 treats if statements differently for indentation, since the things in the if statement are already indented once. This means the next line of the if needs to be indented twice so you can tell the difference between lines in the if and the continuation of the if.
There was a problem hiding this comment.
That's is correct, flake 8 will fail if I indent back this line.
|
One minor comment. |
|
I did not forget about this, I will address the reviews and finish the rest of the PR today 😄 |
|
@antgonza @ElDeveloper comments addressed |
Fixes the objects under data.py
A couple of comments:
check_subclass. This is not needed as the base class cannot be instantiated, so I removed those calls.RawData.createhad aif filepathsas if they're optional, but it is actually a required parameter.