Fix IFS setting in doc deploy script #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 0.5.0 docs publishing job resulted in failure because the openssl command to decrypt the credentials file for uploading the docs errored. The IFS (internal field separator) variable was getting set too broadly at the the level of the entire script instead of just the tag parsing. This was causing the passing of the secrets for decrypting the credential files to fail. This commit updates the IFS usage so it's not affecting the other commands after we split the tag version. This should fix the deploy job for future releases.
mtreinish
added
the
backport stable potential
coruscating
approved these changes
Mar 28, 2023
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
### Summary The 0.5.0 docs publishing job resulted in failure because the openssl command to decrypt the credentials file for uploading the docs errored. The IFS (internal field separator) variable was getting set too broadly at the the level of the entire script instead of just the tag parsing. This was causing the passing of the secrets for decrypting the credential files to fail. This commit updates the IFS usage so it's not affecting the other commands after we split the tag version. This should fix the deploy job for future releases. ### Details and comments (cherry picked from commit 8fe22c9) # Conflicts: # tools/deploy_documentation.sh
|
@Mergifyio backport stable/0.5 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 29, 2023
### Summary The 0.5.0 docs publishing job resulted in failure because the openssl command to decrypt the credentials file for uploading the docs errored. The IFS (internal field separator) variable was getting set too broadly at the the level of the entire script instead of just the tag parsing. This was causing the passing of the secrets for decrypting the credential files to fail. This commit updates the IFS usage so it's not affecting the other commands after we split the tag version. This should fix the deploy job for future releases. ### Details and comments (cherry picked from commit 8fe22c9)
coruscating
pushed a commit
that referenced
this pull request
Mar 29, 2023
This is an automatic backport of pull request #1110 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The 0.5.0 docs publishing job resulted in failure because the openssl command to decrypt the credentials file for uploading the docs errored. The IFS (internal field separator) variable was getting set too broadly at the the level of the entire script instead of just the tag parsing. This was causing the passing of the secrets for decrypting the credential files to fail. This commit updates the IFS usage so it's not affecting the other commands after we split the tag version. This should fix the deploy job for future releases.
Details and comments