Skip to content

Conversation

coruscating
Copy link
Collaborator

@coruscating coruscating commented May 22, 2023

Summary

This PR removes objects scheduled for removal after the 0.5 release and switches deprecation wrappers to the new Terra wrappers introduced in 0.24.

Details and comments

  • Note that deprecating dataclasses will cause the docs to render their fields as *args and **kwargs at present. This is being tracked in Better deprecation handling for dataclasses Qiskit/qiskit#10144.
  • Tests using block_for_results() have also switched to assertExperimentDone() where possible.
  • Adds 0.3.1 release notes back in release notes for 0.4.

@coruscating coruscating added this to the Release 0.6 milestone May 22, 2023
Copy link
Collaborator

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coruscating for housekeeping stuff. This makes codebase much cleaner :)

return _wrapper


def cos(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this is not the scope of this PR, but we can deprecate this entire file. Note that fit functions are now provided by LMFIT string representation, and these functions are no longer used unless users use them on different purpose.

Copy link
Collaborator

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Helena, this PR looks good to me. We can merge this PR with just one more nitpick.

"beta",
new_alias="outcome_prior",
since="0.5",
additional_msg="Instead, use the ``outcome_prior`` argument.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, I've removed it.

Copy link
Collaborator

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please merge once numpy errors are resolved.

@coruscating coruscating enabled auto-merge June 20, 2023 13:02
@coruscating coruscating added this pull request to the merge queue Jun 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 20, 2023
@coruscating coruscating added this pull request to the merge queue Jun 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2023
@coruscating coruscating added this pull request to the merge queue Jun 20, 2023
Merged via the queue into qiskit-community:main with commit 1b38872 Jun 20, 2023
@coruscating coruscating deleted the 0.5-deprecations branch June 20, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants