-
Notifications
You must be signed in to change notification settings - Fork 131
Update SingleTransmonTestBackend for Qiskit Dynamics 0.5.0 #1427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2a700a6
to
89af8c5
Compare
@DanPuzzuoli I noticed some reduction in execution time for the tests using Dynamics. That's probably performance improvements in the new release and not me choosing the wrong translation of the solver options, right? The difference for individual tests is like 3.7 sec vs 4.0 sec ( |
Dynamics 0.5.0 changed the arguments it expects for Solver and underlying models. In particular, instead of `evaluation_mode`, `array_library` and `vectorized` are expected. See https://qiskit-extensions.github.io/qiskit-dynamics/release_notes.html#release-notes-0-5-0
Hmm interesting - to be honest we didn't do any actual benchmarking of the whole package with NumPy execution. I know that @chriseclectic had done some benchmarking of Arraylias when he wrote it and found that it was faster than previous the Just looking at the changes I think they are correct, so I don't think there's any issue there. Setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. We also have versioning-related code in database_service/utils.py
. We could collect them all in the same place but it's not a big deal either way.
That is a good point. There are also |
Dynamics 0.5.0 changed the arguments it expects for Solver and underlying models. In particular, instead of `evaluation_mode`, `array_library` and `vectorized` are expected. See https://qiskit-extensions.github.io/qiskit-dynamics/release_notes.html#release-notes-0-5-0 (cherry picked from commit 6817445)
Queries and tests of installed package versions were spread across a few different modules. Here they are combined into one module (`package_deps.py`) as suggested in qiskit-community#1427.
Queries and tests of installed package versions were spread across a few different modules. Here they are combined into one module (`package_deps.py`) as suggested in qiskit-community#1427.
…1427) (#1428) Dynamics 0.5.0 changed the arguments it expects for Solver and underlying models. In particular, instead of `evaluation_mode`, `array_library` and `vectorized` are expected. See https://qiskit-extensions.github.io/qiskit-dynamics/release_notes.html#release-notes-0-5-0<hr>This is an automatic backport of pull request #1427 done by [Mergify](https://mergify.com). Co-authored-by: Will Shanks <willshanks@us.ibm.com>
Queries and tests of installed package versions were spread across a few different modules. Here they are combined into one module (`package_deps.py`) as suggested in #1427. --------- Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>
Dynamics 0.5.0 changed the arguments it expects for Solver and underlying models. In particular, instead of
evaluation_mode
,array_library
andvectorized
are expected. See https://qiskit-extensions.github.io/qiskit-dynamics/release_notes.html#release-notes-0-5-0