Drop qmlobjdef, support dot syntax in qmlprop. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this approach in fact looks better to me. It's only downside is that the resulted JSON tree is slightly bigger this way with no gains for the QmlWeb itself, but this better fits with what a library with a «parser» in its name should do =). |
| function qml_is_element(str) { | ||
| return str[0].toUpperCase() == str[0]; | ||
| function qml_is_element(name) { | ||
| if (typeof name == "string") { |
akreuzkamp
force-pushed
the
drop-qmlobjdef-alternative
branch
from
86e647c
to
084743d
Compare
qmlobjdef supported only two components, a different format was needed to support assignments like Drag.hotSpot.x: width / 2. Now names with dot-syntax are parsed just like they are in pure js, so we now get nested dot-binary-expressions.
akreuzkamp
force-pushed
the
drop-qmlobjdef-alternative
branch
from
084743d
to
6233a91
Compare
|
LGTM, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qmlobjdef supported only two components, a different format was needed
to support assignments like Drag.hotSpot.x: width / 2.
Now names with dot-syntax are parsed just like they are in pure js, so
we now get nested dot-binary-expressions.
This is just for discussion for now. If we decide for this approach, I can make the unittests work :)