Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop qmlobjdef alternative alias #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stephenmdangelo
Copy link
Member

This builds off of #19 adding deep-subproperties support to property aliases. I haven't made any corresponding changes to the runtime, but I'll do that if this makes sense.

akreuzkamp and others added 2 commits July 9, 2016 14:37
qmlobjdef supported only two components, a different format was needed
to support assignments like Drag.hotSpot.x: width / 2.

Now names with dot-syntax are parsed just like they are in pure js, so
we now get nested dot-binary-expressions.
This allows property aliases to multi-level properties.
@ChALkeR
Copy link
Member

ChALkeR commented Aug 11, 2016

/cc @akreuzkamp
Not sure what would be semantically better here (separate type for aliasdefs or reuse propdefs), I would be fine with any of those, I presume.

@akreuzkamp, what do you think?

@ChALkeR
Copy link
Member

ChALkeR commented Feb 18, 2018

@stephenmdangelo Is this still something you want to achieve? This needs changes in runtime, then.
Also, could you rebase?

@stephenmdangelo
Copy link
Member Author

@ChALkeR I... don’t remember... I’ll look into it. I assume I had a usecase for it and either worked around it or maybe made the runtime change on some branch already. I’ll let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants