Fix for LOGBACK-266 - FixedWindowRollingPolicy MAX_WINDOW_SIZE too small #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 20. 12 is too restrictive, and the users have voted for it to be increased
ceki
added a commit
that referenced
this pull request
Apr 19, 2013
Fix for LOGBACK-266 - FixedWindowRollingPolicy MAX_WINDOW_SIZE too small
|
Thank you David. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for http://jira.qos.ch/browse/LOGBACK-266
I've made the limit overridable by subclasses, and increased the limit from 12 to 20.
However, maybe the limit should be much higher like 100, since some filesystems can do very fast renames (unlike NTFS).. But I didn't want to be too bold so just increased to 20.