Skip to content

Fix for LOGBACK-266 - FixedWindowRollingPolicy MAX_WINDOW_SIZE too small #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2013
Merged

Fix for LOGBACK-266 - FixedWindowRollingPolicy MAX_WINDOW_SIZE too small #110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6b55c9
LOGBACK-266 - allow max window size to be overriden
diroussel Apr 17, 2013
7c926d8
LOGBACK-266 - increase max window size of FixedWindowRollingPolicy to…
diroussel Apr 19, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions logback-core/src/main/java/ch/qos/logback/core/rolling/FixedWindowRollingPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ public class FixedWindowRollingPolicy extends RollingPolicyBase {
public static final String ZIP_ENTRY_DATE_PATTERN = "yyyy-MM-dd_HHmm";

/**
* It's almost always a bad idea to have a large window size, say over 12.
* It's almost always a bad idea to have a large window size, say over 20.
*/
private static int MAX_WINDOW_SIZE = 12;
private static int MAX_WINDOW_SIZE = 20;

public FixedWindowRollingPolicy() {
minIndex = 1;
Expand Down Expand Up @@ -80,9 +80,10 @@ public void start() {
maxIndex = minIndex;
}

if ((maxIndex - minIndex) > MAX_WINDOW_SIZE) {
final int maxWindowSize = getMaxWindowSize();
if ((maxIndex - minIndex) > maxWindowSize) {
addWarn("Large window sizes are not allowed.");
maxIndex = minIndex + MAX_WINDOW_SIZE;
maxIndex = minIndex + maxWindowSize;
addWarn("MaxIndex reduced to " + maxIndex);
}

Expand All @@ -103,6 +104,15 @@ public void start() {
super.start();
}

/**
* Subclasses can override this method to increase the max window size, if required. This is to
* address LOGBACK-266.
* @return
*/
protected int getMaxWindowSize() {
return MAX_WINDOW_SIZE;
}

private String transformFileNamePatternFromInt2Date(String fileNamePatternStr) {
String slashified = FileFilterUtil.slashify(fileNamePatternStr);
String stemOfFileNamePattern = FileFilterUtil.afterLastSlash(slashified);
Expand Down