New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Mandatory OS requerments in script info #3

Closed
Maboroshy opened this Issue Jun 2, 2017 · 13 comments

Comments

Projects
None yet
3 participants
@Maboroshy
Contributor

Maboroshy commented Jun 2, 2017

Some complex scripts, like the new Taskwarrior one, don't run on all OSes QOwnNotes run. I propose new mandatory entry "Supported OS" in script info, which can be either "Any desktop OS", a combination of "Windows", "macOS", "Linux", or maybe even "Windows 7" or "Kubuntu" if the script is that special.

The best way is also implementing it on the code level so the app would "grey out" scripts for unsupported platform.

@pbek

This comment has been minimized.

Member

pbek commented Jun 2, 2017

Such a thing is on my todo list... But I don't know if we should go above operating systems... I cannot check every version of every software that the client might have installed...

@pbek pbek added the enhancement label Jun 2, 2017

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 2, 2017

I think that code part can be platform only, the rest can go to the description.
But the "Supported OS" info seen by user should still be mandatory.

@pbek

This comment has been minimized.

Member

pbek commented Jun 2, 2017

But why do you think the setting should be mandatory? I planned it to be optional, no setting means it should work on every platform.

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 2, 2017

I mean the text line in script description should be mandatory.

@pbek

This comment has been minimized.

Member

pbek commented Jun 3, 2017

So you didn't meant the (to be implemented) array in info.json, but an informal text in the description?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 3, 2017

Yep, but I thought some more about it, and I think your way is better.

@pbek pbek added this to the 17.06.2 milestone Jun 3, 2017

@pbek

This comment has been minimized.

Member

pbek commented Jun 3, 2017

17.06.2

  • when posting a script to the Script repository you can now define which
    platforms are supported by the script with the new platforms parameter
    • for an example please take a look at
      info.json
    • this information will be viewed in the Script repository dialog
    • if the platform you are running QOwnNotes on is not supported by the script
      the item will be colored grey in the script list of the Script repository

@fmakowski, I set "platforms": ["linux", "macos"] for your script. Is that ok?

@fmakowski

This comment has been minimized.

Contributor

fmakowski commented Jun 3, 2017

Sure, I have not yet tested it on mac but I think it should be compatible without any problems.

@pbek

This comment has been minimized.

Member

pbek commented Jun 3, 2017

There now is a new release, could you please test it and report if it works for you?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jun 3, 2017

Works gracefully.

Taskwarrior script is "greyed out" on my Windows 7 VM, but I still can install it. Maybe there should be some extra "Are you sure?" dialog .

@pbek

This comment has been minimized.

Member

pbek commented Jun 3, 2017

Good idea.

@pbek

This comment has been minimized.

Member

pbek commented Jun 6, 2017

17.06.3

  • you can now open the Script repository dialog with the Shortcut
    Alt + + I
  • if you now try to install a script in the Script repository that doesn't
    support your platform you will get a dialog to cancel the installation
  • if you now try to install a script in the Script repository that needs a
    newer version of QOwnNotes you will get a notification to update the application

@pbek pbek modified the milestones: 17.06.3, 17.06.2 Jun 6, 2017

@pbek

This comment has been minimized.

Member

pbek commented Jun 7, 2017

There now is a new release, could you please test it and report if it works for you?

@pbek pbek closed this Jun 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment