Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1037 fn:json-to-xml: 'number-parser' option #1058

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

ChristianGruen
Copy link
Contributor

@ChristianGruen ChristianGruen commented Mar 4, 2024

Issue: #1037

@ChristianGruen ChristianGruen added the Propose Merge without Discussion Change is editorial or minor label Mar 4, 2024
@michaelhkay
Copy link
Contributor

I think the intent is fine, but I find the sentence "The result is obtained by invoking [fn:string] for the result of the function call." confusing.

I would suggest wording along the lines: "The string value of the number element generated in the result will be the value obtained by calling the supplied function, and then converting its result to a string by calling fn:string#1".

@ChristianGruen
Copy link
Contributor Author

…revised, thanks.

@ndw
Copy link
Contributor

ndw commented Mar 12, 2024

The CG agreed to merge this PR without discussion at meeting 069.

@ndw ndw merged commit e984c36 into qt4cg:master Mar 12, 2024
2 checks passed
@ChristianGruen ChristianGruen deleted the 1037 branch March 27, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Propose Merge without Discussion Change is editorial or minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants