Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items before etc #177

Closed
wants to merge 5 commits into from
Closed

Conversation

michaelhkay
Copy link
Contributor

No description provided.

@ndw ndw self-requested a review October 5, 2022 08:32
Copy link
Contributor

@ndw ndw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In items-starting-where, the first example is:

The expression fn:items-starting-where(10 to 20, ->{. gt 12}) returns 13, 14, 15, 16, 17, 18, 19, 20.

I think it would be more consistent to say it returns (13, 14, ..., 20) with parenthesis to indicate that it's a sequence. Also for the last example, (<h2/>,<img/>)

Was the addition of fn:op in this PR intentional?

@ndw
Copy link
Contributor

ndw commented Oct 5, 2022

I see what happened with fn:op. You made a PR for that, then made a new branch for this PR, but didn't go back to master first. So you got fn:op in both PRs. Let's try to remember to merge this PR and not the other one, assuming both are accepted. I imagine that if we merge #173 first, we'll get merge conflicts when we try to merge this one. 😦

@ndw
Copy link
Contributor

ndw commented Oct 5, 2022

Also: you've added fn:op to the function catalog, but you haven't referenced it from the specification itself, so it doesn't appear.

@michaelhkay
Copy link
Contributor Author

michaelhkay commented Oct 5, 2022 via email

ndw added a commit to ndw/qtspecs-xslt4 that referenced this pull request Oct 10, 2022
ndw added a commit to ndw/qtspecs-xslt4 that referenced this pull request Oct 10, 2022
@ChristianGruen
Copy link
Contributor

Proposal: #149

@ndw
Copy link
Contributor

ndw commented Nov 11, 2022

Resolved by #199, I believe.

@ndw ndw closed this Nov 11, 2022
@michaelhkay michaelhkay deleted the items-before-etc branch July 9, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants