Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue109 xsl note #353

Merged
merged 5 commits into from
Feb 22, 2023
Merged

Issue109 xsl note #353

merged 5 commits into from
Feb 22, 2023

Conversation

michaelhkay
Copy link
Contributor

Addresses issue #109 and issue #87. Unfortunately the PR also includes the unrelated commits for issue 22.

@michaelhkay
Copy link
Contributor Author

Note also: I propose that if we accept this proposal, issues #19 and #84 can be closed with no further action.

@ndw
Copy link
Contributor

ndw commented Feb 17, 2023

If you add fix #19 and fix #84 to the description, they'll be closed automatically when the PR is merged.

I'm not sure if doing that in this comment will be sufficient. It might be.

@ndw
Copy link
Contributor

ndw commented Feb 22, 2023

Accepted 21 February 2023

@ndw ndw merged commit c9a8c09 into qt4cg:master Feb 22, 2023
This was referenced Feb 22, 2023
Closed
Closed
@michaelhkay michaelhkay mentioned this pull request Apr 19, 2023
Closed
@michaelhkay michaelhkay added Completed PR has been applied, tests written and tagged, no further action needed XSLT An issue related to XSLT Tests Added Tests have been added to the test suites labels Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Completed PR has been applied, tests written and tagged, no further action needed Tests Added Tests have been added to the test suites XSLT An issue related to XSLT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelhkay @ndw