518: Add transitive-closure() function #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joewiz
reviewed
May 24, 2023
| <fos:example> | ||
| <fos:test use="transitive-closure-data"> | ||
| <fos:expression>transitive-closure($data//person[@id=2], function{//person[@manager]=@id})/string(@id)</fos:expression> | ||
| <fos:result>("3", "4", "6")</fos:result> |
There was a problem hiding this comment.
Should the result ("3", "4", "6") contain "6"? Person 6's manager is 3, not 2.
There was a problem hiding this comment.
Ah, I think I get it. With the first iteration, we get persons who have 2 as a manager (persons 3 and 4), and with the following iteration we get all people who have 3 or 4 as a manager (person 6) - and thus the answer is 3, 4, and 6. (I'd been misreading the context for //person as $data/person[@id = 2], whereas in fact it's all of $data.)
michaelhkay
removed
the
Revise
|
The CG accepted this PR at meeting 038 |
|
Closes issue #518 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.