Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

216: fn:unparsed-text: End-of-line characters #794

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

ChristianGruen
Copy link
Contributor

Closes #216. See this issue for more details on the proposed change.

@ChristianGruen ChristianGruen added the Tests Needed Tests need to be written or merged label Oct 30, 2023
Copy link
Contributor

@michaelhkay michaelhkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. "As known from XML" is not very idiomatic, and more importantly, not very precise. I'd suggest a specific reference to section 2.11 End of Line Handling: "are normalized as described in [XML] section 2.11 End of Line Handling.
  2. Why XML 1.0 and not XML 1.1?
  3. This is a backwards incompatibility. I'm not necessarily opposed to it but the fact needs highlighting in Appendix G. Might there be applications that need to know what line endings were used? Should this be added to a new options parameter?

@ChristianGruen
Copy link
Contributor Author

  1. "As known from XML" is not very idiomatic, and more importantly, not very precise. I'd suggest a specific reference to section 2.11 End of Line Handling: "are normalized as described in [XML] section 2.11 End of Line Handling.

Thanks. That’s what I tried to do, but I might need help how to do it properly:

image

  1. Why XML 1.0 and not XML 1.1?

Happy to change that.

  1. This is a backwards incompatibility. I'm not necessarily opposed to it but the fact needs highlighting in Appendix G. Might there be applications that need to know what line endings were used? Should this be added to a new options parameter?

I had already added an item to Appendix G, but I assume it’s supposed to be more comprehensive, or wrongly formatted/edited?

@ndw
Copy link
Contributor

ndw commented Nov 13, 2023

This worked for me:

         <p>Test: <xspecref spec="XML" ref="sec-line-ends"/>.</p>

@ndw ndw added the Propose Merge without Discussion Change is editorial or minor label Nov 13, 2023
@ndw
Copy link
Contributor

ndw commented Nov 14, 2023

The group agreed to merge this PR at meeting 054

@ndw ndw merged commit a5b5235 into qt4cg:master Nov 14, 2023
2 checks passed
@ChristianGruen ChristianGruen removed the Propose Merge without Discussion Change is editorial or minor label Jan 2, 2024
@ChristianGruen ChristianGruen removed the Tests Needed Tests need to be written or merged label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fn:unparsed-text: End-of-line characters
3 participants