660: Static functions, default parameters, XPST0017 #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelhkay
requested changes
Nov 6, 2023
There was a problem hiding this comment.
The use of XPST0017 doesn't match the description of this error in the appendix. Existing uses of XPST0017 all relate to errors in function calls, not errors in function declarations. In addition, this particular error is XQuery-specific which might mean that an XQ code is more appropriate. I would go for a new error code such as XQST0148.
|
Thanks, revised as suggested. |
ChristianGruen
removed
the
Propose Merge without Discussion
michaelhkay
approved these changes
Nov 6, 2023
ChristianGruen
added
the
Propose Merge without Discussion
|
The group agreed to merge this PR at meeting 053 |
ChristianGruen
removed
the
Propose Merge without Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve chosen XPST0017 over XPST0003 (it felt more intuitive to me).
Closes #660.