Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizers with high atols should likely be using np.complex128 #5536

Closed
dabacon opened this issue Jun 16, 2022 · 1 comment
Closed

Optimizers with high atols should likely be using np.complex128 #5536

dabacon opened this issue Jun 16, 2022 · 1 comment
Labels
area/transformers kind/bug-report Something doesn't seem to work. triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add

Comments

@dabacon
Copy link
Collaborator

dabacon commented Jun 16, 2022

We have flakes on tests that have quite high atols due to the move from np.complex128 to np.complex64 default. See #5535 for example. These are sometimes optimizers that are very numerically unstable. We should likely use np.complex128 for these optimizers (say ones with atols of 2e-5 or worse)
@dabacon dabacon added the kind/bug-report Something doesn't seem to work. label Jun 16, 2022
@dabacon dabacon mentioned this issue Jun 16, 2022
Merged
@MichaelBroughton MichaelBroughton added triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add area/transformers labels Jun 16, 2022
CirqBot pushed a commit that referenced this issue Jun 17, 2022
@dabacon
Fix more flakes (#5537)
8d725d6 
#5536
@dabacon dabacon mentioned this issue Jun 24, 2022
Merged
CirqBot pushed a commit that referenced this issue Jun 24, 2022
@dabacon
Make transformers use higher precision (#5601)
60a9be6 
Fixing flakes.  Part of #5536
@dabacon
Copy link
Collaborator Author

dabacon commented Jun 29, 2022

We have rolled back the change in default #5636 so this is no longer a relevant issue.

@dabacon dabacon closed this as completed Jun 29, 2022
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@dabacon @rht
Fix more flakes (quantumlib#5537)
5ff570a 
quantumlib#5536
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@dabacon @rht
Make transformers use higher precision (quantumlib#5601)
3353dcb 
Fixing flakes.  Part of quantumlib#5536
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this issue Oct 31, 2024
@dabacon
Make transformers use higher precision (quantumlib#5601)
c99f820 
Fixing flakes.  Part of quantumlib#5536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/transformers kind/bug-report Something doesn't seem to work. triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dabacon @MichaelBroughton