[Pasqal updates] PasqalDevice class generalization #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @balopat ! Here is the second PR. Also, I was wondering: is it okay to do two PR's simultaneously if they are unrelated? I suppose it is not recommended, I was just wondering since it could help speed up the process. |
Absolutely, feel free to open multiple ones! I'll have a look at this one today! |
balopat
suggested changes
Jul 17, 2020
cirq/pasqal/pasqal_device.py
Outdated
|
|
||
|
|
||
| @cirq.value.value_equality | ||
| class PasqalDevice(cirq.devices.Device): | ||
| """A Pasqal Device with qubits placed on a 3D grid.""" | ||
| """A generic Pasqal device.""" |
There was a problem hiding this comment.
A bit more documentation here would be very helpful (you can just rephrase a bunch of the text you had in the documentation) for users to understand the intent of this class: When is this useful? Why would someone want to use an unconstrained Pasqal device vs the 3D one?
cirq/pasqal/pasqal_device.py
Outdated
|
|
||
| for q in qubits: | ||
| if not isinstance(q, ThreeDGridQubit): | ||
| if not isinstance(q, self.supported_qubit_type): | ||
| raise TypeError('Unsupported qubit type: {!r}'.format(q)) |
There was a problem hiding this comment.
To make the error message more helpful, you could list the supported qubit types.
|
|
||
| @property | ||
| def maximum_qubit_number(self): | ||
| return 100 |
There was a problem hiding this comment.
we are so in the NISQ era ;)
cirq/pasqal/pasqal_device.py
Outdated
| if not isinstance(qub, ThreeDGridQubit): | ||
| raise ValueError('{} is not a 3D grid qubit ' | ||
| if not isinstance(qub, self.supported_qubit_type): | ||
| raise ValueError('{} is not a valid qubit ' |
There was a problem hiding this comment.
Similar to init, please clarify what are the accepted types for this device.
balopat
approved these changes
Jul 20, 2020
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
This was referenced Jul 21, 2020
CirqBot
pushed a commit
that referenced
this pull request
Jul 22, 2020
CirqBot
pushed a commit
that referenced
this pull request
Jul 29, 2020
This the third child-PR of #3126 , following #3141 . - The accepted gate set is updated to: - Accept only specific multi-qubit gates - Accept the Hadamard gate - The noise model is updated accordingly and is now device dependent, in preparation for the addition of new devices whose noise model will naturally differ from the standard - A specific converter for non-native gate decomposition is adapted from the `neutral_atoms` module
CirqBot
pushed a commit
that referenced
this pull request
Jul 31, 2020
This is the fifth child-PR of #3126, following #3160. `PasqalVirtualDevice`, which enforces the constraints typically found in a physical device, is added to the module. These constraints were present in `PasqalDevice` before its generalisation in #3141 . They are now reincorporated here. This is the last code PR of the Pasqal updates, after which all that is left is to incorporate the documentation.
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
This the second child-PR of quantumlib#3126 , following quantumlib#3133 . - Generalizes `PasqalDevice`, removing ties to the physical placement of the qubits. - `PasqalDevice` now serves as the parent class of all future Pasqal devices, only enforcing constraints expected to exist on all future devices. - `PasqalDevice`can also be used as the device for submission of explicitly unconstrained circuits to Pasqal's devices. A new device class, `PasqalVirtualDevice`, will subclass the new `PasqalDevice` and recover the hardware constraints of the current `PasqalDevice` on a future PR.
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
This the fourth child-PR of quantumlib#3126 , following quantumlib#3141 and in parallel with quantumlib#3160 . `ThreeDGridQubit` is removed from the `pasqal` module, as all dependencies have been eliminated and it can be fully replaced by `ThreeDQubit`.
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
This the third child-PR of quantumlib#3126 , following quantumlib#3141 . - The accepted gate set is updated to: - Accept only specific multi-qubit gates - Accept the Hadamard gate - The noise model is updated accordingly and is now device dependent, in preparation for the addition of new devices whose noise model will naturally differ from the standard - A specific converter for non-native gate decomposition is adapted from the `neutral_atoms` module
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
This is the fifth child-PR of quantumlib#3126, following quantumlib#3160. `PasqalVirtualDevice`, which enforces the constraints typically found in a physical device, is added to the module. These constraints were present in `PasqalDevice` before its generalisation in quantumlib#3141 . They are now reincorporated here. This is the last code PR of the Pasqal updates, after which all that is left is to incorporate the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This the second child-PR of #3126 , following #3133 .
PasqalDevice, removing ties to the physical placement of the qubits.PasqalDevicenow serves as the parent class of all future Pasqal devices, only enforcing constraints expected to exist on all future devices.PasqalDevicecan also be used as the device for submission of explicitly unconstrained circuits to Pasqal's devices.A new device class,
PasqalVirtualDevice, will subclass the newPasqalDeviceand recover the hardware constraints of the currentPasqalDeviceon a future PR.