Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pasqal updates] Removing ThreeDGridQubit #3161

Merged
merged 13 commits into from
Jul 22, 2020
Merged

[Pasqal updates] Removing ThreeDGridQubit #3161

merged 13 commits into from
Jul 22, 2020

Conversation

HGSilveri
Copy link
Collaborator

This the fourth child-PR of #3126 , following #3141 and in parallel with #3160 .

ThreeDGridQubit is removed from the pasqal module, as all dependencies have been eliminated and it can be fully replaced by ThreeDQubit.

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Jul 21, 2020
@HGSilveri
Copy link
Collaborator Author

Hi @balopat ! Thank you very much for all your help so far, I'm happy to say we are nearly done. This PR should be very straightforward to merge, #3160 probably not so much but it is still okay. Please take a look whenever you can, thanks!

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 21, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 21, 2020
@CirqBot CirqBot merged commit 3076bba into quantumlib:master Jul 22, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 22, 2020
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this pull request Aug 23, 2020
@HGSilveri
[Pasqal updates] Removing ThreeDGridQubit (quantumlib#3161)
8a0b054 
This the fourth child-PR of quantumlib#3126 , following quantumlib#3141  and in parallel with quantumlib#3160 .

`ThreeDGridQubit` is removed from the `pasqal` module, as all dependencies have been eliminated and it can be fully replaced by `ThreeDQubit`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HGSilveri @balopat @googlebot @CirqBot