[Pasqal updates] Updated gate set #3160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sorry for the wait on this @HGSilveri - I was distracted in the last two days with an event. Will be back to this in the coming days. |
Collaborator
Author
|
No worries @balopat , thanks for all your help! By the way, I believe that the failed CI check is unrelated to this PR. |
balopat
reviewed
Jul 27, 2020
balopat
suggested changes
Jul 28, 2020
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
This is looking good, two small comments
| (cirq.ops.HPowGate, cirq.ops.CNotPowGate, cirq.ops.CZPowGate, | ||
| cirq.ops.CCZPowGate, cirq.ops.CCXPowGate)): | ||
| expo = op.gate.exponent | ||
| valid_op = np.isclose(expo, np.around(expo, decimals=0)) |
Contributor
There was a problem hiding this comment.
How would this work with parametrized gates? The type of exponent is Union[float, sympy.Basic] - it could be parametrized. I think you should make sure you're handling that here and cover that flow with tests.
Collaborator
Author
There was a problem hiding this comment.
You're right, I made the appropriate changes.
balopat
reviewed
Jul 28, 2020
cirq/pasqal/pasqal_device.py
Outdated
| (cirq.ops.HPowGate, cirq.ops.CNotPowGate, cirq.ops.CZPowGate, | ||
| cirq.ops.CCZPowGate, cirq.ops.CCXPowGate)): | ||
| expo = op.gate.exponent | ||
| if not isinstance(expo, sympy.Basic): |
Contributor
There was a problem hiding this comment.
- Use
cirq.is_parametrized(op)- that should take care of other parameters as well. - Is the Pasqal device going to handle non-integer exponent and/or parametrized gates from PhasedXPowGate, XPowGate, YPowGate, ZPowGate? If not, then maybe we should just bring up the parametrization check further up, to the beginning in this method.
Collaborator
Author
There was a problem hiding this comment.
- Ok, will do.
- Yes, we'll handle non-integer exponents for these. As for the parametrization, we won't necessarily handle that, but we support the parameter substitution for actual values in
PasqalSampler.run_sweep, so we have to allow those here.
balopat
approved these changes
Jul 29, 2020
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
CirqBot
pushed a commit
that referenced
this pull request
Jul 31, 2020
This is the fifth child-PR of #3126, following #3160. `PasqalVirtualDevice`, which enforces the constraints typically found in a physical device, is added to the module. These constraints were present in `PasqalDevice` before its generalisation in #3141 . They are now reincorporated here. This is the last code PR of the Pasqal updates, after which all that is left is to incorporate the documentation.
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
This the fourth child-PR of quantumlib#3126 , following quantumlib#3141 and in parallel with quantumlib#3160 . `ThreeDGridQubit` is removed from the `pasqal` module, as all dependencies have been eliminated and it can be fully replaced by `ThreeDQubit`.
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
This the third child-PR of quantumlib#3126 , following quantumlib#3141 . - The accepted gate set is updated to: - Accept only specific multi-qubit gates - Accept the Hadamard gate - The noise model is updated accordingly and is now device dependent, in preparation for the addition of new devices whose noise model will naturally differ from the standard - A specific converter for non-native gate decomposition is adapted from the `neutral_atoms` module
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
This is the fifth child-PR of quantumlib#3126, following quantumlib#3160. `PasqalVirtualDevice`, which enforces the constraints typically found in a physical device, is added to the module. These constraints were present in `PasqalDevice` before its generalisation in quantumlib#3141 . They are now reincorporated here. This is the last code PR of the Pasqal updates, after which all that is left is to incorporate the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This the third child-PR of #3126 , following #3141 .
neutral_atomsmodule