Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated experiments #5674

Merged
merged 9 commits into from Jul 7, 2022
Merged

Remove deprecated experiments #5674

merged 9 commits into from Jul 7, 2022

Conversation

dstrain115
Copy link
Collaborator 

- Removes deprecated functions, classes, and modules from experiments.
- CrossEntropyResult and CrossEntropyResult are still there since they
need json backwards compatibility.  Will follow up with later PR for it.

@dstrain115
Minor updates to development page
64bcc59 
- Change Foxtail to Sycamore since Foxtail is deprecated.
- Add some clarification that instructions are for linux.
@dstrain115
t pMerge branch 'master' of https://github.com/quantumlib/Cirq
b6dbd1e
@dstrain115
Remove deprecated Experiments
e5cae0f 
- Removes deprecated functions, classes, and modules from experiments.
- CrossEntropyResult and CrossEntropyResult are still there since they
need json backwards compatibility.  Will follow up with later PR for it.
@dstrain115 dstrain115 requested review from mrwojtek, a team, vtomole and cduck as code owners July 7, 2022 11:19
@CirqBot CirqBot added the size: XL lines changed >1000 label Jul 7, 2022
dabacon
dabacon approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dabacon dabacon added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 7, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 7, 2022
@CirqBot CirqBot merged commit 446b7ec into quantumlib:master Jul 7, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 7, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@dstrain115 @rht
Remove deprecated experiments (quantumlib#5674)
00b8246 
    - Removes deprecated functions, classes, and modules from experiments.
    - CrossEntropyResult and CrossEntropyResult are still there since they
    need json backwards compatibility.  Will follow up with later PR for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabacon dabacon dabacon approved these changes

@mrwojtek mrwojtek Awaiting requested review from mrwojtek

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@mpharrigan mpharrigan Awaiting requested review from mpharrigan mpharrigan was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: XL lines changed >1000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dstrain115 @dabacon @CirqBot