Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated SingleQubitGate #5686

Merged
merged 11 commits into from Jul 8, 2022
Merged

Remove deprecated SingleQubitGate #5686

merged 11 commits into from Jul 8, 2022

Conversation

dstrain115
Copy link
Collaborator

Note: cirq.testing.SingleQubitGate still exists for brevity when writing tests.)

@dstrain115 dstrain115 requested review from a team, vtomole and cduck as code owners July 8, 2022 16:48
@CirqBot CirqBot added the size: M 50< lines changed <250 label Jul 8, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@pavoljuhas
Copy link
Collaborator

One last leftover reference at

Cirq/docs/build/custom_gates.ipynb

Line 231 in 30b6638

"An alternative to inheriting from `cirq.Gate` is to inherit from `cirq.SingleQubitGate`, in which case defining `_num_qubits_` is unnecessary. An example of a defining a two-qubit gate is shown below."

pavoljuhas
pavoljuhas approved these changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after removing SingleQubitGate reference at

Cirq/docs/build/custom_gates.ipynb

Line 231 in 30b6638

"An alternative to inheriting from `cirq.Gate` is to inherit from `cirq.SingleQubitGate`, in which case defining `_num_qubits_` is unnecessary. An example of a defining a two-qubit gate is shown below."

@dstrain115 dstrain115 added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 8, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 8, 2022
@CirqBot CirqBot merged commit b47cee8 into quantumlib:master Jul 8, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 8, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@dstrain115 @rht
Remove deprecated SingleQubitGate (quantumlib#5686)
42dacc0 
Note: cirq.testing.SingleQubitGate still exists for brevity when writing tests.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar tanujkhattar was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dstrain115 @pavoljuhas @CirqBot