Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove circuits.CircuitDag #5733

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Remove circuits.CircuitDag #5733

merged 4 commits into from
Jul 12, 2022

Conversation

dstrain115
Copy link
Collaborator

This class has moved to contrib.

Removed CircuitDag and Unique from the old location
and have removed them from the global namespace.
Users can still access cirq.contrib.CircuitDag.

@dstrain115
Remove circuits.CircuitDag
2e8a55c 
This class has moved to contrib.

Removed CircuitDag and Unique from the old location
and have removed them from the global namespace.
Users can still access cirq.contrib.CircuitDag.
@dstrain115 dstrain115 requested review from a team, vtomole and cduck as code owners July 12, 2022 13:34
@dstrain115 dstrain115 requested a review from viathor July 12, 2022 13:34
@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jul 12, 2022
vtomole
vtomole approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dstrain115 dstrain115 added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 12, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 12, 2022
@CirqBot CirqBot merged commit cd55e0d into quantumlib:master Jul 12, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 12, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@dstrain115 @rht
Remove circuits.CircuitDag (quantumlib#5733)
ab12106 
This class has moved to contrib.

Removed CircuitDag and Unique from the old location
and have removed them from the global namespace.
Users can still access cirq.contrib.CircuitDag.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@dstrain115
Remove circuits.CircuitDag (quantumlib#5733)
6168b02 
This class has moved to contrib.

Removed CircuitDag and Unique from the old location
and have removed them from the global namespace.
Users can still access cirq.contrib.CircuitDag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole approved these changes

@cduck cduck Awaiting requested review from cduck

@viathor viathor Awaiting requested review from viathor viathor was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: L 250< lines changed <1000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstrain115 @vtomole @CirqBot