Add ZipLongest to cirq_google #6074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Apr 21, 2023
dstrain115
commented
- This class is similar to cirq.Zip but repeats the last value if the combined sweeps are not the same length.
- This class is similar to cirq.Zip but repeats the last value if the combined sweeps are not the same length.
dstrain115
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
|
Can this go into |
pavoljuhas
reviewed
Apr 21, 2023
pavoljuhas
reviewed
Apr 21, 2023
pavoljuhas
reviewed
Apr 21, 2023
pavoljuhas
reviewed
Apr 22, 2023
pavoljuhas
reviewed
Apr 22, 2023
pavoljuhas
requested changes
Apr 22, 2023
pavoljuhas
reviewed
Apr 24, 2023
cirq-core/cirq/study/sweeps_test.py
Outdated
| sweep1 = cirq.ZipLongest(cirq.Points('a', [1, 2, 3]), cirq.Points('b', [4, 5, 6, 7])) | ||
| sweep2 = cirq.ZipLongest(cirq.Points('a', [1, 2, 3]), cirq.Points('b', [4, 5, 6, 7])) | ||
| sweep3 = cirq.ZipLongest(cirq.Points('a', [1, 2]), cirq.Points('b', [4, 5, 6, 7])) | ||
| sweep4 = cirq.Zip(cirq.Points('a', [1, 2]), cirq.Points('b', [4, 5, 6, 7])) |
There was a problem hiding this comment.
As it is, both sweep3 == sweep4 and hash(sweep3) == hash(sweep4) evaluate to True.
Perhaps we need to use a strict type(other) is Zip in the Zip.__eq__ function
Cirq/cirq-core/cirq/study/sweeps.py
Lines 294 to 297 in 58d0205
and insert ZipLongest or a similar type-marker to the hashed tuple at
Cirq/cirq-core/cirq/study/sweeps.py
Lines 364 to 365 in 58d0205
There was a problem hiding this comment.
Changed to use 'is not Zip' and also changed the test to use Cirq's equality tester.
pavoljuhas
requested changes
Apr 24, 2023
pavoljuhas
approved these changes
Apr 24, 2023
dstrain115
added
the
automerge
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Add ZipLongest to cirq_google - This class is similar to cirq.Zip but repeats the last value if the combined sweeps are not the same length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.