-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for couplers #6681
Add validation for couplers #6681
Conversation
- Adds validation to `GridDevice` for Coupler Qid objects.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6681 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 1074 1074
Lines 92126 92156 +30
=======================================
+ Hits 90124 90154 +30
Misses 2002 2002 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % few nits
Co-authored-by: Seneca Meeks <senecacmeeks@gmail.com>
@senecameeks It looks like the commit suggestion broke the CLA. Can you make sure your gmail address is properly registered under the CLA? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Approval
GridDevice
for Coupler Qid objects.