Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for couplers #6681

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

dstrain115
Copy link
Collaborator

  • Adds validation to GridDevice for Coupler Qid objects.

- Adds validation to `GridDevice` for Coupler Qid objects.
@dstrain115 dstrain115 requested review from wcourtney, vtomole, verult and a team as code owners July 29, 2024 13:20
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (c25678e) to head (5da7be7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6681   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files        1074     1074           
  Lines       92126    92156   +30     
=======================================
+ Hits        90124    90154   +30     
  Misses       2002     2002           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@senecameeks senecameeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % few nits

cirq-google/cirq_google/devices/grid_device_test.py Outdated Show resolved Hide resolved
@dstrain115
Copy link
Collaborator Author

@senecameeks It looks like the commit suggestion broke the CLA. Can you make sure your gmail address is properly registered under the CLA?

Copy link
Collaborator

@senecameeks senecameeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Approval

@dstrain115 dstrain115 enabled auto-merge (squash) August 1, 2024 16:08
@dstrain115 dstrain115 merged commit 3fee420 into quantumlib:main Aug 1, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants