Adds a simple scheduler that just follows the moment structure. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strilanc
approved these changes
Feb 13, 2018
cirq/schedules/schedulers.py
Outdated
| device.validate_scheduled_operation(schedule, scheduled_op) | ||
| # Increment time for next moment by max of ops during this moment. | ||
| max_duration = max((device.duration_of(op) for op in moment.operations), | ||
| key=Duration.total_picos) |
There was a problem hiding this comment.
Duration implements comparison operations, so this key argument should be unnecessary.
t += max(device.duration_of(op) for op in moment.operations)
There was a problem hiding this comment.
Funny I tried that and if failed but now it works. ¯_(ツ)_/¯
cirq/schedules/schedulers.py
Outdated
| schedule = Schedule(device) | ||
| t = Timestamp() | ||
| for moment in circuit.moments: | ||
| if len(moment.operations) == 0: |
There was a problem hiding this comment.
if not moment.operations:
cirq/schedules/schedulers_test.py
Outdated
| schedule = schedulers.moment_schedule(device, circuit) | ||
|
|
||
| zero_ns = Timestamp() | ||
| second = Timestamp(nanos=20) |
There was a problem hiding this comment.
Maybe call it a tick instead of a "second".
There was a problem hiding this comment.
ha that is "second" as in "2nd" not the time. Changed to twenty_ns
cirq/schedules/schedulers.py
Outdated
| from cirq.time import Timestamp | ||
|
|
||
|
|
||
| def moment_schedule(device: Device, circuit: Circuit): |
There was a problem hiding this comment.
Name is okay, but not great. Maybe moment_by_moment_schedule?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will be useful at is a very simple conceptual scheduler.