Skip to content

Import grpc-bom in quarkus-bom instead of managing individual grpc artifacts #9403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ppalaga opened this issue May 18, 2020 · 2 comments · Fixed by #9411
Closed

Import grpc-bom in quarkus-bom instead of managing individual grpc artifacts #9403

ppalaga opened this issue May 18, 2020 · 2 comments · Fixed by #9411
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Milestone
1.5.0.CR1

Comments

@ppalaga
Copy link
Contributor

ppalaga commented May 18, 2020

Description
Since the GRPC extension was moved to Quarkus source tree, we (Camel Quarkus) have hard time to align dependencies coming from Quarkus with the one coming from Camel. This is because Quarkus runtime BOM manages just grpc-api and grpc-stub. We'd actually need much more, nearly all listed in https://repo1.maven.org/maven2/io/grpc/grpc-bom/1.29.0/grpc-bom-1.29.0.pom

So is there a reason not to import the whole grpc-bom in quarkus-bom?
@ppalaga ppalaga added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label May 18, 2020
ppalaga added a commit to apache/camel-quarkus that referenced this issue May 18, 2020
@ppalaga
Workaround quarkusio/quarkus#9403
667b9f1
@geoand
Copy link
Contributor

geoand commented May 18, 2020

cc @cescoffier

@gsmet gsmet mentioned this issue May 18, 2020
Merged
@gsmet
Copy link
Member

gsmet commented May 18, 2020

I created a PR after discussing with @cescoffier .

github-actions bot pushed a commit to apache/camel-quarkus that referenced this issue May 19, 2020
@ppalaga @actions-user
Workaround quarkusio/quarkus#9403
5f4f7b2
github-actions bot pushed a commit to apache/camel-quarkus that referenced this issue May 20, 2020
@ppalaga @github-actions
Workaround quarkusio/quarkus#9403
18e246e
@gsmet gsmet added this to the 1.5.0.CR1 milestone May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Milestone
1.5.0.CR1
Development

Successfully merging a pull request may close this issue.

Define gRPC version by using the BOM gsmet/quarkus
3 participants
@gsmet @ppalaga @geoand