Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: align console log to file log #2526

Merged
merged 1 commit into from
May 21, 2019

Conversation

loicmathieu
Copy link
Contributor

This fixes #2488 .

I propose to align console and file log default configuration to log at ALL level.

IMHO, it's even mode important for console logs as it's used while developing, and the DEBUG level is more interesting at developement time than runtime.

@kenfinnigan
Copy link
Member

I'm not sure I agree that console logging should be ALL.

A concern here is that it will significantly slow down startup and produce lots of information in the console that most of the time is not beneficial.

Would like to hear @dmlloyd's thoughts on this

@stuartwdouglas
Copy link
Member

The root log level is still INFO, so it won't show debug messages unless they have been explicitly configured.

I actually agree with this approach, otherwise if I want to enable debug logging for a specific category I need to both set the category logger, and set the console min level.

@stuartwdouglas stuartwdouglas requested a review from dmlloyd May 21, 2019 01:30
Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this is fine.

@dmlloyd dmlloyd merged commit 5973310 into quarkusio:master May 21, 2019
@kenfinnigan kenfinnigan added this to the 0.16.0 milestone May 21, 2019
@loicmathieu loicmathieu deleted the feat/console_log branch May 31, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console log and file log minimum level are not the same
4 participants