feat: align console log to file log #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I agree that console logging should be A concern here is that it will significantly slow down startup and produce lots of information in the console that most of the time is not beneficial. Would like to hear @dmlloyd's thoughts on this |
|
The root log level is still INFO, so it won't show debug messages unless they have been explicitly configured. I actually agree with this approach, otherwise if I want to enable debug logging for a specific category I need to both set the category logger, and set the console min level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2488 .
I propose to align console and file log default configuration to log at ALL level.
IMHO, it's even mode important for console logs as it's used while developing, and the DEBUG level is more interesting at developement time than runtime.