-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change quarkus-cache config phase from BUILD_TIME to RUN_TIME #30000
Conversation
I wonder if that change is worth mentioning in the release note. |
This comment has been minimized.
This comment has been minimized.
The native build failure is related, I'm fixing it. |
dd720f8
to
cbeffc6
Compare
This comment has been minimized.
This comment has been minimized.
cbeffc6
to
49ed1f7
Compare
This comment has been minimized.
This comment has been minimized.
ℹ️ I'm aware of the native build issue, I'll try to fix it tomorrow. |
Any luck with this? |
b2821cd
to
cde31ba
Compare
@geoand Sorry for the delay. I pushed a few changes, the native issue should be fixed now. |
Nice, thanks! |
Sorry, I closed it by accident... |
I think both should be mentioned as they are related, so I added the proper label - that leaves you on the hook to provide a small blurb which @gsmet can use in the release announcement :) |
Copying from #29934 (comment): The quarkus-cache config will be settable at run time starting Quarkus 2.16.0. It will also be possible to change some of the cache config values in real time (without restarting the app) using the programmatic API. Here's a preview of the cache doc from 2.16 that explains how to do that. |
Fixes #29934.
This PR changes the entire
quarkus-cache
config phase fromBUILD_TIME
toRUN_TIME
. To make that possible, I had to refactor the bytecode recording a bit and move its execution time fromSTATIC_INIT
toRUNTIME_INIT
.