Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change quarkus-cache config phase from BUILD_TIME to RUN_TIME #30000

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

gwenneg
Copy link
Member

@gwenneg gwenneg commented Dec 21, 2022

Fixes #29934.

This PR changes the entire quarkus-cache config phase from BUILD_TIME to RUN_TIME. To make that possible, I had to refactor the bytecode recording a bit and move its execution time from STATIC_INIT to RUNTIME_INIT.

@gwenneg gwenneg marked this pull request as ready for review December 21, 2022 09:40
@gwenneg
Copy link
Member Author

gwenneg commented Dec 21, 2022

I wonder if that change is worth mentioning in the release note.

@quarkus-bot

This comment has been minimized.

@gwenneg
Copy link
Member Author

gwenneg commented Dec 21, 2022

The native build failure is related, I'm fixing it.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@gwenneg
Copy link
Member Author

gwenneg commented Jan 2, 2023

ℹ️ I'm aware of the native build issue, I'll try to fix it tomorrow.

@geoand
Copy link
Contributor

geoand commented Jan 5, 2023

information_source I'm aware of the native build issue, I'll try to fix it tomorrow.

Any luck with this?

@gwenneg gwenneg marked this pull request as draft January 6, 2023 10:03
@gwenneg gwenneg force-pushed the #29934-config branch 3 times, most recently from b2821cd to cde31ba Compare January 6, 2023 10:59
@gwenneg gwenneg marked this pull request as ready for review January 6, 2023 13:19
@gwenneg
Copy link
Member Author

gwenneg commented Jan 6, 2023

@geoand Sorry for the delay. I pushed a few changes, the native issue should be fixed now.

@geoand
Copy link
Contributor

geoand commented Jan 9, 2023

Nice, thanks!

@geoand geoand closed this Jan 9, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jan 9, 2023
@geoand geoand reopened this Jan 9, 2023
@quarkus-bot quarkus-bot bot removed the triage/invalid This doesn't seem right label Jan 9, 2023
@geoand
Copy link
Contributor

geoand commented Jan 9, 2023

Sorry, I closed it by accident...

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 9, 2023
@gwenneg gwenneg merged commit e579cd2 into quarkusio:main Jan 9, 2023
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Jan 9, 2023
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 9, 2023
@gwenneg gwenneg deleted the #29934-config branch January 9, 2023 10:39
@gwenneg
Copy link
Member Author

gwenneg commented Jan 9, 2023

@geoand Do you think this PR and/or #30005 should be mentioned in the community release note (the blog post)?

@geoand
Copy link
Contributor

geoand commented Jan 9, 2023

I think both should be mentioned as they are related, so I added the proper label - that leaves you on the hook to provide a small blurb which @gsmet can use in the release announcement :)

@geoand
Copy link
Contributor

geoand commented Jan 9, 2023

Copying from #29934 (comment):

The quarkus-cache config will be settable at run time starting Quarkus 2.16.0. It will also be possible to change some of the cache config values in real time (without restarting the app) using the programmatic API. Here's a preview of the cache doc from 2.16 that explains how to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set quarkus-cache properties at runtime
2 participants