Fix elytron properties perf issues #6358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Dec 30, 2019
| @Override | ||
| public Provider[] get() { | ||
| return new Provider[] { new WildFlyElytronProvider() }; | ||
| return providers; |
There was a problem hiding this comment.
Maybe you can make the whole supplier static and reuse it at both locations?
|
Also, can you check in the other security implementations that we don't have this pattern? |
loicmathieu
force-pushed
the
fix/perf-issues
branch
from
66130aa to
2207f88
Compare
|
@gsmet I add the same performance optimization to the JDBC implementation. OAuth2 and OIDC didn't suffers from the same issue. |
loicmathieu
force-pushed
the
fix/perf-issues
branch
from
2207f88 to
ba2f7f8
Compare
|
@gsmet I also review the LDAP and JPA security extensions currently under review, LDAP has the same issue (I add a review comment), JPA doesn't seems to have it (not 100% sure as it's a complex extension and I just have a quick look). |
stuartwdouglas
approved these changes
Jan 1, 2020
gsmet
approved these changes
Jan 2, 2020
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some performance testing, I discover, thanks to profiler CPU flamegraph, that the Elytron Properties implementation uses a lot of CPU cycles to create the
WilldFlyElytronProvider.It apears that the security provider supplier is called on each request calls, and triggers the creation of a new
WilldFlyElytronProvider.Creating a unique
WilldFlyElytronProviderand returing it from the supplier instead of creating it each time fix the issue.