Add a way of setting the maximum stack size.

Author: PetterS

module.c

@@ -21,6 +21,7 @@ typedef struct {
 
 // The exception raised by this module.
 static PyObject *JSException = NULL;
+static PyObject *StackOverflow = NULL;
 // Converts a JSValue to a Python object.
 //
 // Takes ownership of the JSValue and will deallocate it (refcount reduced by 1).
@@ -210,7 +211,11 @@ static PyObject *quickjs_to_python(ContextData *context_obj, JSValue value) {
 		JSValue exception = JS_GetException(context);
 		JSValue error_string = JS_ToString(context, exception);
 		const char *cstring = JS_ToCString(context, error_string);
-		PyErr_Format(JSException, "%s", cstring);
+		if (strstr(cstring, "stack overflow") != NULL) {
+			PyErr_Format(StackOverflow, "%s", cstring);
+		} else {
+			PyErr_Format(JSException, "%s", cstring);
+		}
 		JS_FreeCString(context, cstring);
 		JS_FreeValue(context, error_string);
 		JS_FreeValue(context, exception);
@@ -349,6 +354,18 @@ static PyObject *context_set_time_limit(ContextData *self, PyObject *args) {
 	Py_RETURN_NONE;
 }
 
+// _quickjs.Context.set_max_stack_size
+//
+// Sets the max stack size in bytes.
+static PyObject *context_set_max_stack_size(ContextData *self, PyObject *args) {
+	Py_ssize_t limit;
+	if (!PyArg_ParseTuple(args, "n", &limit)) {
+		return NULL;
+	}
+	JS_SetMaxStackSize(self->context, limit);
+	Py_RETURN_NONE;
+}
+
 // _quickjs.Context.memory
 //
 // Sets the CPU time limit of the context. This will be used in an interrupt handler.
@@ -420,6 +437,10 @@ static PyMethodDef context_methods[] = {
      (PyCFunction)context_set_time_limit,
      METH_VARARGS,
      "Sets the CPU time limit in seconds (C function clock() is used)."},
+    {"set_max_stack_size",
+     (PyCFunction)context_set_max_stack_size,
+     METH_VARARGS,
+     "Sets the maximum stack size in bytes. Default is 256kB."},
     {"memory", (PyCFunction)context_memory, METH_NOARGS, "Returns the memory usage as a dict."},
     {"gc", (PyCFunction)context_gc, METH_NOARGS, "Runs garbage collection."},
     {NULL} /* Sentinel */
@@ -468,11 +489,16 @@ PyMODINIT_FUNC PyInit__quickjs(void) {
 	if (JSException == NULL) {
 		return NULL;
 	}
+	StackOverflow = PyErr_NewException("_quickjs.StackOverflow", JSException, NULL);
+	if (StackOverflow == NULL) {
+		return NULL;
+	}
 
 	Py_INCREF(&Context);
 	PyModule_AddObject(module, "Context", (PyObject *)&Context);
 	Py_INCREF(&Object);
 	PyModule_AddObject(module, "Object", (PyObject *)&Object);
 	PyModule_AddObject(module, "JSException", JSException);
+	PyModule_AddObject(module, "StackOverflow", StackOverflow);
 	return module;
 }

quickjs/__init__.py

@@ -11,6 +11,7 @@ def test():
 Context = _quickjs.Context
 Object = _quickjs.Object
 JSException = _quickjs.JSException
+StackOverflow = _quickjs.StackOverflow
 
 
 class Function:
@@ -32,6 +33,10 @@ def set_time_limit(self, limit):
         with self._lock:
             return self._context.set_time_limit(limit)
 
+    def set_max_stack_size(self, limit):
+        with self._lock:
+            return self._context.set_max_stack_size(limit)
+
     def memory(self):
         with self._lock:
             return self._context.memory()

setup.py

@@ -22,6 +22,7 @@
     # on computers where it is not installed.
     extra_link_args = ["-Wl,-Bstatic", "-lpthread"]
 
+
 def get_c_sources(include_headers=False):
     sources = ['module.c'] + glob.glob("third-party/*.c")
     if include_headers:
@@ -45,7 +46,7 @@ def get_c_sources(include_headers=False):
       author_email="petter.strandmark@gmail.com",
       name='quickjs',
       url='https://github.com/PetterS/quickjs',
-      version='1.3.1',
+      version='1.4.0',
       description='Wrapping the quickjs C library.',
       long_description=long_description,
       packages=["quickjs"],

test_quickjs.py

@@ -308,6 +308,25 @@ def test_garbage_collection(self):
         f.gc()
         self.assertLessEqual(f.memory()["obj_count"], initial_count)
 
+    def test_deep_recursion(self):
+        f = quickjs.Function(
+            "f", """
+            function f(v) {
+                if (v <= 0) {
+                    return 0;
+                } else {
+                    return 1 + f(v - 1);
+                }
+            }
+        """)
+
+        self.assertEqual(f(100), 100)
+        limit = 500
+        with self.assertRaises(quickjs.StackOverflow):
+            f(limit)
+        f.set_max_stack_size(2000 * limit)
+        self.assertEqual(f(limit), limit)
+
 
 class Strings(unittest.TestCase):
     def test_unicode(self):